Fix trailing frame capture after recording ended#55704
Open
huntie wants to merge 5 commits intofacebook:mainfrom
Open
Fix trailing frame capture after recording ended#55704huntie wants to merge 5 commits intofacebook:mainfrom
huntie wants to merge 5 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
huntie
changed the title
huntie
force-pushed
the
export-D93863310
branch
from
0257479 to
d989bc9
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Pull Request resolved: facebook#55704 Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
huntie
force-pushed
the
export-D93863310
branch
from
d989bc9 to
00fefc4
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Pull Request resolved: facebook#55704 Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
huntie
force-pushed
the
export-D93863310
branch
from
00fefc4 to
6da3bc7
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Pull Request resolved: facebook#55704 Previously, this could lead to capturing an additional 120-240 new frames. Also refactor to de-nest and simplify coroutine logic. Changelog: [Internal] Differential Revision: D93863310
Summary: Small refactor — locate public methods first, sort private methods in call order. Changelog: [Internal] Differential Revision: D94366535
…facebook#55731) Summary: Changelog: [Internal] Differential Revision: D94256691
Summary: Previously, screenshot capture was initiated on a background thread, so `PixelCopy` could run during a later frame than the one being reported. Screenshots now correctly correspond to their frame metrics callback. Changelog: [Internal] Differential Revision: D94368259
Summary: The shared `bitmapBuffer` could be overwritten by a new `PixelCopy` request on the main thread while a previous frame's encoding coroutine was still reading from it. Each frame now gets its own bitmap, recycled after encoding. NOTE: This will come at a slight perf cost (allocating extra new bitmaps in memory), for the tradeoff of correctness. Changelog: [Internal] Differential Revision: D94368260
Summary: Previously, this could lead to capturing an additional 120-240 new frames. Changelog: [Internal] Differential Revision: D93863310
huntie
force-pushed
the
export-D93863310
branch
from
6da3bc7 to
2d23996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, this could lead to capturing an additional 120-240 new frames.
Also refactor to de-nest and simplify coroutine logic.
Changelog: [Internal]
Differential Revision: D93863310