Capture initial screenshot when starting frame timing trace#55720
Open
rubennorte wants to merge 1 commit intofacebook:mainfrom
Open
Capture initial screenshot when starting frame timing trace#55720rubennorte wants to merge 1 commit intofacebook:mainfrom
rubennorte wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [internal] When tracing starts, the frame metrics listener only fires when new frames are rendered. This means if no UI changes occur during a trace, no screenshots are captured. This also causes the initial state of the UI to be missing from the trace. This change captures an initial screenshot immediately when `start()` is called, ensuring there's always at least one frame recorded at the beginning of a trace regardless of whether UI changes occur. The implementation also refactors the frame emission logic into a shared `emitFrameTiming()` method to eliminate code duplication between the frame metrics listener and the initial capture. Differential Revision: D94223073
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94223073. |
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
When tracing starts, the frame metrics listener only fires when new frames are rendered. This means if no UI changes occur during a trace, no screenshots are captured. This also causes the initial state of the UI to be missing from the trace.
This change captures an initial screenshot immediately when
start()is called, ensuring there's always at least one frame recorded at the beginning of a trace regardless of whether UI changes occur.The implementation also refactors the frame emission logic into a shared
emitFrameTiming()method to eliminate code duplication between the frame metrics listener and the initial capture.Differential Revision: D94223073