Fix Docker networking race condition on first startup#2157
Closed
bigjohncodes wants to merge 1 commit intofastapi:masterfrom
Closed
Fix Docker networking race condition on first startup#2157bigjohncodes wants to merge 1 commit intofastapi:masterfrom
bigjohncodes wants to merge 1 commit intofastapi:masterfrom
Conversation
- Add health check to Traefik proxy with ping endpoint - Make backend depend on proxy being healthy before starting - Ensures Docker networks are fully initialized before backend binds ports - Prevents connection timeout issues on first 'docker compose up' This fixes a race condition where the backend container would start and bind to port 8000 before Docker's network bridges were fully configured, causing connection timeouts from the host machine. The fix ensures the backend waits for the proxy (Traefik) to be healthy before starting, which guarantees all network routes and port forwarding rules are properly established.
Author
|
Hi maintainers! 👋 Could you please add the This PR fixes a race condition that causes connection timeouts on first startup, so Thank you! |
Contributor
|
This was marked as potentially AI generated and will be closed now. If this is an error, please provide additional details, make sure to read the docs about contributing and AI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
docker compose up -dfor the first time, users may experience connection timeout issues when trying to access the backend API (port 8000) from their host machine, even though the container starts successfully and health checks pass.This is caused by a race condition where the backend container starts and binds to port 8000 before Docker's network bridges and port forwarding rules are fully configured, particularly when multiple services with custom networks start simultaneously.
Solution
This PR fixes the issue by:
Changes
healthcheckconfiguration to the proxy service incompose.override.yml--ping=trueflag to Traefik command to enable the ping endpointdepends_onwithcondition: service_healthyfor the backend serviceTesting
Tested by:
docker compose downto remove all containers and networksdocker compose up -d(fresh start)Benefits
Fixes connection timeout issues on first
docker compose up.