chore: add apache license header script & CI check#1404
chore: add apache license header script & CI check#1404jescalada wants to merge 9 commits intofinos:mainfrom
Conversation
Note: For files with shebangs in the first line, we add the license after the shebang
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
There was a problem hiding this comment.
This is where the interesting stuff happens. So you don't have to dig through the diff! 🙂
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
==========================================
+ Coverage 81.25% 81.51% +0.25%
==========================================
Files 65 65
Lines 4657 4722 +65
Branches 792 792
==========================================
+ Hits 3784 3849 +65
Misses 858 858
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prevents infinite loops with `quicktype` validation failing due to the license header being present
|
If we're avoiding the eslint plugin route rather than building our own tool/utility I'd recommend https://github.com/fsfe/reuse-tool from the |
|
@jescalada could you rebase this and resolve conflicts? However, it might be worth getting your other two PRs set to go into the release merged first so you can get all the conflicts in one go. |
|
@06kellyjac Here's a new PR implementing this using the ESLint plugin, I wasn't aware it existed! It's quite easy to use, too. #1447 @kriswest Will close this PR if the new one is more appropriate 👍🏼 |
New PR at #1447
Fixes #1002. Inspired by #1253, credit goes to @sam-holmes2 for the original PR 🙂
Changes
add-license-headers.tsscript to/scriptsin order to add license headers automaticallynpm run add-license-headers/src/config/generatedfiles from having the license appended, due to infinite loop withquicktypegenerated configcheck-license-headers.tsfor checking headers in CIlint.yml)