Skip to content

Comments

fix(py): fix dotprompt deadlock#4567

Merged
MengqinShen merged 1 commit intomainfrom
elisa/fix/dotprompt-deadlock
Feb 11, 2026
Merged

fix(py): fix dotprompt deadlock#4567
MengqinShen merged 1 commit intomainfrom
elisa/fix/dotprompt-deadlock

Conversation

@MengqinShen
Copy link
Contributor

@MengqinShen MengqinShen commented Feb 11, 2026 •
edited
Loading

  • Change Dotprompt schema_resolver to async to prevent thread pool deadlocks(The Problem: The recipe prompt uses a structured output schema. When Dotprompt tried to resolve this schema synchronously, it deadlocked the thread pool, causing the prompt execution to hang or fail).

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 11, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@MengqinShen MengqinShen marked this pull request as ready for review February 11, 2026 04:00
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 11, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@MengqinShen MengqinShen requested a review from yesudeep February 11, 2026 04:00
@MengqinShen MengqinShen enabled auto-merge (squash) February 11, 2026 04:00
@MengqinShen MengqinShen merged commit 148f230 into main Feb 11, 2026
19 checks passed
@MengqinShen MengqinShen deleted the elisa/fix/dotprompt-deadlock branch February 11, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesudeep yesudeep yesudeep approved these changes

@huangjeff5 huangjeff5 huangjeff5 approved these changes

Assignees

No one assigned

Labels

fix python Python

Projects

Genkit Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MengqinShen @yesudeep @huangjeff5 @MengqinShen-GL