Conversation
| arch = stage0_arch_map.get(args.arch, args.arch) | ||
| init = os.path.join(os.sep, 'bootstrap-seeds', 'POSIX', arch, 'kaem-optional-seed') | ||
| target_rel = os.path.relpath(generator.target_dir, os.getcwd()) | ||
| run('env', '-i', 'DOCKER_BUILDKIT=1', |
There was a problem hiding this comment.
Why do we hardcode DOCKER_BUILDKIT=1 here? Won't this cause needless failures on systems without BuildKit installed (e.g. systems with older Docker versions)?
There was a problem hiding this comment.
It was a part of #413. If you don't want it, remove it.
There was a problem hiding this comment.
Are you willing to guide this PR to a mergeable state? This needs addressing from my perspective to be merged.
If you aren't willing to guide this PR to be merged, that's fine - no one owes anyone anything in open source - but I won't keep this PR open indefinitely in that case.
fosslinux
left a comment
fosslinux
left a comment
There was a problem hiding this comment.
Thanks for the work! Looks good overall, just a few improvements needed.
| ARG GID | ||
| ARG HOME | ||
| ENV PATH=/bin:/usr/sbin:/usr/bin | ||
| RUN set -eu; \ |
There was a problem hiding this comment.
Do you know what the purpose of all this is?
| ENV SOURCE_DATE_EPOCH=1 | ||
| ENV KCONFIG_NOTIMESTAMP=1 |
There was a problem hiding this comment.
It would probably be better for these to be 0 in line with what we use everywhere else.
(I'm not so convinced we should have KCONFIG_NOTIMESTAMP anyways)
There was a problem hiding this comment.
| ENV SOURCE_DATE_EPOCH=1 | |
| ENV KCONFIG_NOTIMESTAMP=1 | |
| ENV SOURCE_DATE_EPOCH=0 |
| 'docker', 'build', | ||
| '--build-arg=ARCH='+ arch, | ||
| '--build-arg=TARGET=' + target_rel, | ||
| '--build-arg=SOURCE_DATE_EPOCH=1', |
There was a problem hiding this comment.
Similar to above, let's make this 0.
There was a problem hiding this comment.
| '--build-arg=SOURCE_DATE_EPOCH=1', | |
| '--build-arg=SOURCE_DATE_EPOCH=0', |
| arch = stage0_arch_map.get(args.arch, args.arch) | ||
| init = os.path.join(os.sep, 'bootstrap-seeds', 'POSIX', arch, 'kaem-optional-seed') | ||
| target_rel = os.path.relpath(generator.target_dir, os.getcwd()) | ||
| run('env', '-i', 'DOCKER_BUILDKIT=1', |
There was a problem hiding this comment.
Are you willing to guide this PR to a mergeable state? This needs addressing from my perspective to be merged.
If you aren't willing to guide this PR to be merged, that's fine - no one owes anyone anything in open source - but I won't keep this PR open indefinitely in that case.
|
I provided this PR as a continuation of a previous PR that also stalled due to gatekeeping. I have long since forked and don't depend on this Dockerfile myself, although I hope it helps others who wish to explore this in future. Happy bootstrapping. |
Not sure what you mean by this at all. We are very willing to help code be merged, but we aren't going to merge just any code that comes our way. It needs to fit with the existing codebase and be maintainable. Both of these PRs have stalled not because we don't want to merge it, but because no one has found the time to make it mergeable. Regardless, all the best with your use of live-bootstrap, would love to hear of any improvements you do make, even if they are not in a mergeable state. |
4 participants
A continuation of PR #413.
Can be run with:
./rootfs.py --docker