Skip to content

fix(cli): start lifetime modules before use in CLI commands #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A386official wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): start lifetime modules before use in CLI commands #818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions internal/cli/ctl/moduleinit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,26 @@ func getCfgBlockModule(ctx *cli.Context) (*container.C, module.Module, error) {
return nil, nil, err
}

// Start all lifetime modules so that backends (e.g. storage.imapsql)
// are fully initialized before the CLI attempts to use them.
// Without this, fields like imapsql.Back remain nil and calls such
// as EnableUpdatePipe dereference a nil pointer.
if err := c.Lifetime.StartAll(); err != nil {
return nil, nil, err
}

return c, mod, nil
}

func openStorage(ctx *cli.Context) (module.Storage, error) {
_, mod, err := getCfgBlockModule(ctx)
c, mod, err := getCfgBlockModule(ctx)
if err != nil {
return nil, err
}

storage, ok := mod.(module.Storage)
if !ok {
c.Lifetime.StopAll()
return nil, cli.Exit(fmt.Sprintf("Error: configuration block %s is not an IMAP storage", ctx.String("cfg-block")), 2)
}

Expand All @@ -104,13 +113,14 @@ func openStorage(ctx *cli.Context) (module.Storage, error) {
}

func openUserDB(ctx *cli.Context) (module.PlainUserDB, error) {
_, mod, err := getCfgBlockModule(ctx)
c, mod, err := getCfgBlockModule(ctx)
if err != nil {
return nil, err
}

userDB, ok := mod.(module.PlainUserDB)
if !ok {
c.Lifetime.StopAll()
return nil, cli.Exit(fmt.Sprintf("Error: configuration block %s is not a local credentials store", ctx.String("cfg-block")), 2)
}

Expand Down