[WIP] Fix AsyncSeq migration issues and Fable feedback#232
Merged
dsyme merged 2 commits intorepo-assist/v4-bcl-iasyncenumerable-migration-3b81040f29c8a5a6from Feb 22, 2026
Merged
Conversation
4 tasks
6 tasks
…MPILER - In AsyncSeq.fs: wrap AsyncSeq<'T> type alias, AsyncSeqImpl<'T>, and AsyncSeqEnumeratorExtensions with #if FABLE_COMPILER / #else / #endif. For Fable: AsyncSeq<'T> is a library-specific interface with GetEnumerator() returning IAsyncSeqEnumerator<'T>, avoiding ValueTask. For non-Fable: keeps existing BCL IAsyncEnumerable<'T> alias and ValueTask-based adapter. - In AsyncSeq.fs: guard UnfoldAsyncEnumerator's IAsyncEnumerable<'T> implementation of the library AsyncSeq<'T> interface instead. - In AsyncSeq.fsi: add #if FABLE_COMPILER guard to expose IAsyncSeqEnumerator<'T> and define AsyncSeq<'T> as interface for Fable builds; keep BCL type alias for non-Fable. Verified: dotnet build succeeds, 190/190 tests pass, dotnet fable compiles without errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot stopped work on behalf of
dsyme due to an error
February 22, 2026 10:54
dsyme
merged commit 0afeff0
into
repo-assist/v4-bcl-iasyncenumerable-migration-3b81040f29c8a5a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.Bcl.AsyncInterfacesto Fable test project to fixValueTask<T>unavailable errorofAsyncEnumandtoAsyncEnumas[<Obsolete>]inAsyncSeq.fsandAsyncSeq.fsi🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.