Conversation
These mirror the corresponding Seq module functions and complement the existing AsyncSeq.sum combinator: - sumBy / sumByAsync: map-then-sum using sync/async projection - average: compute mean of a numeric async sequence - averageBy / averageByAsync: map-then-average using sync/async projection All raise InvalidArgumentException on empty sequences (average variants). 6 new tests added; all 200 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Pull request created: #245 |
6 tasks
dsyme
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Adds five new aggregation combinators that mirror the corresponding
Seqmodule functions, complementing the existingAsyncSeq.sum:The
average*variants raiseInvalidArgumentExceptionwhen the sequence is empty (same asSeq.average).Motivation
AsyncSeq.sumalready exists, andsumBy/average/averageByare the natural companions. Users frequently need to compute weighted sums and averages over async streams (e.g. aggregating metrics, sensor readings). Having these avoids users reaching fortoArrayAsync+Array.averagewhich buffers the entire sequence.Implementation
All functions are
inlinewith the appropriate SRTP constraints (same pattern assum):sumBy/sumByAsync— fold withGenericZeroaccumulator, applying projection firstaverage/averageBy/averageByAsync— fold tracking(sum, count), then callLanguagePrimitives.DivideByIntTest Status
✅ Build: succeeded (no errors, 2 pre-existing warnings for
groupByAsync)✅ Tests: all 200 tests pass (194 existing + 6 new)
New tests cover: basic correctness against
List.sumBy/List.averageBy, async projections, and empty-sequence exception foraverage.