[Repo Assist] Set DtdProcessing.Parse explicitly as the default for XML parsing#1636
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
[Repo Assist] Set DtdProcessing.Parse explicitly as the default for XML parsing#1636github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
DtdProcessing.Parse is the default on .NET Core and was the behavior before the XXE fix that was reverted (#1633). Making this explicit ensures the intended behavior is clear and documented in code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
✅ Pull request created: #1636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Sets
DtdProcessing = DtdProcessing.Parseexplicitly inXmlElement.CreateandXmlElement.CreateListinXmlRuntime.fs.Context
DtdProcessing.Parseis the default on .NET Core (unlike .NET Framework whereDtdProcessing.Prohibitis the default). This was the effective behavior before the XXE fix PR (#1596) that was reverted in #1633. Making the setting explicit:Changes
open System.Xmlto imports inXmlRuntime.fsXmlElement.Create(reader: TextReader): now usesXmlReaderwithXmlReaderSettings(DtdProcessing = DtdProcessing.Parse)before loading intoXDocumentXmlElement.CreateList(reader: TextReader): same — usesXmlReaderwith explicitDtdProcessing.ParsesettingsTest Status
✅ Build succeeded
✅ All 69 XML tests passed (
dotnet test --filter "Xml")