Skip to content

Comments

Allow S3 metadata key published_image_metadata to be undefined#317

Merged
saubhikdattagithub merged 1 commit intomainfrom
fix/s3-metadata-key-used-without-check
Feb 19, 2026
Merged

Allow S3 metadata key published_image_metadata to be undefined#317
saubhikdattagithub merged 1 commit intomainfrom
fix/s3-metadata-key-used-without-check

Conversation

@NotTheEvilOne
Copy link
Contributor

What this PR does / why we need it:
This PR changes how S3 metadata key published_image_metadata is accessed.

Which issue(s) this PR fixes:
Related #189

@NotTheEvilOne NotTheEvilOne self-assigned this Feb 19, 2026
@NotTheEvilOne NotTheEvilOne added the bug Something isn't working label Feb 19, 2026
@NotTheEvilOne NotTheEvilOne added this to the 2026-02 milestone Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.51%. Comparing base (e682361) to head (0975f2d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          42       42           
  Lines        2157     2158    +1     
=======================================
+ Hits         1974     1975    +1     
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne NotTheEvilOne force-pushed the fix/s3-metadata-key-used-without-check branch from df56a59 to 167760a Compare February 19, 2026 10:55
Related: #189
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>
@NotTheEvilOne NotTheEvilOne force-pushed the fix/s3-metadata-key-used-without-check branch from 167760a to 0975f2d Compare February 19, 2026 10:59
Copy link
Contributor

@saubhikdattagithub saubhikdattagithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, canary freeze shortly

@saubhikdattagithub saubhikdattagithub merged commit a776256 into main Feb 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants