fix(ci): Remove tsconfig paths entry breaking Bun scripts#16476
Open
jaffrepaul wants to merge 3 commits intomasterfrom
Open
fix(ci): Remove tsconfig paths entry breaking Bun scripts#16476jaffrepaul wants to merge 3 commits intomasterfrom
jaffrepaul wants to merge 3 commits intomasterfrom
Conversation
The paths mapping for remark-mdx-images was redirecting Bun's runtime module resolution to a .d.ts file, causing "Missing 'default' export" errors in CI workflows (algolia-index, lint-404s, etc.). The ambient module declaration in src/@types/remark-mdx-images.d.ts still provides TypeScript types via typeRoots without the paths entry. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Add missing `attributes: []` property to ImportDeclaration object in remark-mdx-images. The estree types require this property but the package doesn't provide it, causing TypeScript errors. This patch fixes the root cause instead of working around it with tsconfig paths redirects that broke Bun's runtime resolution. Also removes the now-unnecessary type declaration file. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Algolia indexing failure introduced in #16419 (yarn to pnpm migration).
The problem:
PR #16419 added a tsconfig
pathsentry redirectingremark-mdx-imagesto a.d.tsfile. This worked for TypeScript but broke Bun, which tried to execute the.d.tsas a runtime module, causingSyntaxError: Missing 'default' export.The fix:
Use
pnpm patchto fix the actual type error inremark-mdx-images. The package is missingattributes: []on anImportDeclarationobject, which newer estree types require.Changes:
patches/remark-mdx-images@3.0.0.patchwith the one-line fixpathsworkaroundsrc/@types/remark-mdx-images.d.tsVerified locally:
pnpm lint:ts✅pnpm test✅ (124 tests)