-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(core): Add span serialization utilities #19140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lms24
merged 11 commits into
lms/feat-span-first
from
lms/span-first-pr7-span-serialization
Feb 4, 2026
+384
−18
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e54e151
feat(core): Add span serialization utilities for V2 spans
Lms24 2774fed
rename, add tests, add 2 stage conversion
Lms24 5a6d17b
fix lint errro
Lms24 fc18e22
Update packages/core/src/tracing/sentrySpan.ts
Lms24 2c7a20a
remove unnecessary guard and clear up spanv2json confusion
Lms24 e6ac9fc
small optimization
Lms24 a4324e4
size limit
Lms24 7ec8aa8
s/spanJsonToSerializedSpan/streamedSpanJsonToSerializedSpan
Lms24 72ac303
Merge branch 'lms/feat-span-first' into lms/span-first-pr7-span-seria…
Lms24 49b9670
vue size limit
Lms24 1eaa995
lint
Lms24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this even more visible that this is an internal API: Should this maybe prefixed with
_INTERNAL_?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users should never interact with
SentrySpandirectly but leave it up tostart*Span*APIs which kind ofSpan(as in interface) they get back or work with.I oriented myself here primarily on the already existing
getSpanJSONmethod. In light of keeping the name short for bundle size, I'd tend to keep it that way, unless you think we should still do it?