Use sub-second timestamps in logs#2018
Open
martinstuecklschwaiger wants to merge 6 commits intogetsentry:masterfrom
Open
Use sub-second timestamps in logs#2018martinstuecklschwaiger wants to merge 6 commits intogetsentry:masterfrom
martinstuecklschwaiger wants to merge 6 commits intogetsentry:masterfrom
Conversation
Sentry UI shows timestamps as `Feb 18, 17:48:27.000 CET`
This fixes the Psalm warning
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
Hi @martinstuecklschwaiger! Thanks for opening the PR! It looks good to me. Since you added a fix for pre-1970 timestamps, can you also add a quick test for that? |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
martinstuecklschwaiger
force-pushed
the
sub-second-log-timestamps
branch
from
8eedac0 to
eeb5748
Compare
martinstuecklschwaiger
force-pushed
the
sub-second-log-timestamps
branch
from
eeb5748 to
cc2f5ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry UI shows timestamps as
Feb 18, 17:48:27.000 CET(milliseconds as000).Description
Breadcrumb timestamps use floats. Monolog also supports sub-second timestamps from DateTimeImmutable. This pull request uses split-second timestamps for creating Breadcrumbs in the Monolog BreadcrumbHandler.
U: Seconds since the Unix Epoch https://www.php.net/manual/en/datetime.format.php#:~:text=01%3A07%20%2B0200-,U,Seconds%20since%20the%20Unix%20Epoch,-(January%201%201970u: Microsecondshttps://www.php.net/manual/en/datetime.format.php#:~:text=u,Microseconds