ref(sentry-core): Refactor logs batching into generic Batcher#1018
Merged
szokeasaurusrex merged 1 commit intomasterfrom Mar 2, 2026
Merged
ref(sentry-core): Refactor logs batching into generic Batcher#1018szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex merged 1 commit intomasterfrom
Conversation
Refactor the logs batcher into a generic `Batcher<T>`, so that we can reuse it for metrics and any future types. Closes #1007 Closes [RUST-158](https://linear.app/getsentry/issue/RUST-158/refactor-logs-batching-into-a-reusable-generic-batchert) Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/generic-batcher
branch
from
bd1fb97 to
53e52e4
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 2, 2026
Refactor the logs batcher into a generic `Batcher<T>`, so that we can reuse it for metrics and any future types. Closes #1007 Closes [RUST-158](https://linear.app/getsentry/issue/RUST-158/refactor-logs-batching-into-a-reusable-generic-batchert) Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/generic-batcher
branch
2 times, most recently
from
4044c5f to
53e52e4
Compare
lcian
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the logs batcher into a generic
Batcher<T>, so that we can reuse it for metrics and any future types.Split off from #997 — however, in this PR, I aimed to minimize the diff between the
logs.rsandbatch.rsfiles, so thatgitwould recognize the change as a rename, not a file deletion and new file.Closes #1007
Closes RUST-158
Co-authored-by: Joris Bayer joris.bayer@sentry.io