feat: Reworking wsl detection logic to avoid false-positives in containers#2064
Draft
rtrevi wants to merge 1 commit intogit-ecosystem:mainfrom
Draft
feat: Reworking wsl detection logic to avoid false-positives in containers#2064rtrevi wants to merge 1 commit intogit-ecosystem:mainfrom
rtrevi wants to merge 1 commit intogit-ecosystem:mainfrom
Conversation
Author
|
First contribution, be gentle :) |
Contributor
|
Sadly #1813 is sort of a collection of curve-balls:
In the interop-capable case the Browser should to be started by raw (or an equivalent |
Author
A bit out of my depth there 😅 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes inspection of
/proc/versionstrings for detecting WSL1 or WSL2./proc/versionis inherited by containers within WSL, causing gcm to wrongly identify these containers as WSL distros: Bug: GCM Misidentifies Docker Containers Running on WSL2 Due to /proc/version #1813Inspects
/proc/sys/fs/binfmt_misc/WSLInteropand/proc/sys/fs/binfmt_misc/WSLInterop-Latefor respectively detecting WSL1 or WSL2. This is consistent across distros and the files aren't inherited into containers.Removes inspection of
WSL_INTEROPenv var for detecting WSL2. Deemed not necessary anymore.