Add explicit permissions to GitHub Actions workflows#90
Merged
Conversation
Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add explicit permissions to workflow files
Add explicit permissions to GitHub Actions workflows
Nov 20, 2025
jonrohan
approved these changes
Nov 20, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit permissions declarations to GitHub Actions workflows, following security best practices by implementing the principle of least privilege. Previously, these workflows relied on default permissions which could grant unnecessary access.
- Added job-level
permissions: contents: readto both workflow files - Both workflows only perform read operations (checkout, build, test), making this the minimal required permission set
- The publish workflow uses npm token secrets for registry publishing, requiring no GitHub write permissions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/nodejs.yml |
Added contents: read permission to build job for checkout and CI operations |
.github/workflows/publish.yml |
Added contents: read permission to publish-npm job for checkout before npm publishing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liuliu-dev
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow files lacked explicit permission declarations, relying on default permissions which violate least-privilege principles.
Changes
Added
permissions: contents: readat job level in:.github/workflows/nodejs.yml(build job).github/workflows/publish.yml(publish-npm job)Both workflows only perform read operations (checkout, build, test). The publish workflow uses npm token secrets for registry publishing, requiring no GitHub write permissions.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.