Use new feature flag for repository properties#3492
Open
henrymercer wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the feature flag for repository properties from use_repository_properties to use_repository_properties_v2. This change allows the feature to be rolled out exclusively to CodeQL Action versions that include the improved error handling introduced in PR #3421. The feature flag name change is a versioning strategy to ensure only newer Action versions with better error tolerance will be able to enable the repository properties feature.
Changes:
- Updated the Feature enum value from
"use_repository_properties"to"use_repository_properties_v2"in the TypeScript source - Maintained backward compatibility by keeping the enum name
UseRepositoryPropertiesand environment variableCODEQL_ACTION_USE_REPOSITORY_PROPERTIESunchanged - Generated JavaScript files in
lib/directory reflect the TypeScript changes
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/feature-flags.ts | Updated Feature.UseRepositoryProperties enum value to use v2 suffix |
| lib/upload-sarif-action.js | Generated JavaScript reflecting the feature flag update |
| lib/upload-sarif-action-post.js | Generated JavaScript reflecting the feature flag update |
| lib/upload-lib.js | Generated JavaScript reflecting the feature flag update |
| lib/start-proxy-action.js | Generated JavaScript reflecting the feature flag update |
| lib/start-proxy-action-post.js | Generated JavaScript reflecting the feature flag update |
| lib/setup-codeql-action.js | Generated JavaScript reflecting the feature flag update |
| lib/resolve-environment-action.js | Generated JavaScript reflecting the feature flag update |
| lib/init-action.js | Generated JavaScript reflecting the feature flag update, including usage in loadRepositoryProperties function |
| lib/init-action-post.js | Generated JavaScript reflecting the feature flag update |
| lib/autobuild-action.js | Generated JavaScript reflecting the feature flag update |
| lib/analyze-action.js | Generated JavaScript reflecting the feature flag update |
| lib/analyze-action-post.js | Generated JavaScript reflecting the feature flag update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append
v2to the repository properties FF, so we can roll out repository properties only to CodeQL Action versions with the improved error handling introduced in #3421.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, CCR, ...).Products:
analysis-kinds: code-scanning.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist