Implement missing amendment for directive 4-11 from misra C 2012 amendment 3#878
Merged
MichaelRFairhurst merged 2 commits intomainfrom Mar 31, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the missing amendment for directive 4-11 as specified in MISRA C 2012 amendment 3 by adding a new query.
- Added a change note for the new query validating low precision periodic trigonometric function calls.
- Updates the change notes file with details on the query's detection logic for 32-bit and 64-bit floating point types.
Files not reviewed (7)
- amendments.csv: Language not supported
- c/misra/src/rules/DIR-4-11/LowPrecisionPeriodicTrigonometricFunctionCall.ql: Language not supported
- c/misra/test/rules/DIR-4-11/LowPrecisionPeriodicTrigonometricFunctionCall.expected: Language not supported
- c/misra/test/rules/DIR-4-11/LowPrecisionPeriodicTrigonometricFunctionCall.qlref: Language not supported
- c/misra/test/rules/DIR-4-11/test.c: Language not supported
- cpp/common/src/codingstandards/cpp/exclusions/c/Contracts.qll: Language not supported
- rule_packages/c/Contracts.json: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
lcartey
approved these changes
Mar 31, 2025
…lement-missing-sin-precision-amendment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Almost missed this amendment as it was marked blocked in the spreadsheet.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
DIR-4-11Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.