Update expected test results after frontend update#988
Merged
jketema merged 1 commit intogithub:nextfrom Jan 6, 2026
Merged
Conversation
8c81721 to
ae21fb5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates test expected results and test annotations following a frontend update. The changes reflect how the CodeQL frontend now reports source locations and appear to address test failures caused by these frontend changes.
- Updated expected test results for AUTOSAR rule A2-10-5 to reflect new location reporting for template variable declarations
- Modified test annotations for MISRA RULE-14-3 to add line numbering and update expected behavior markers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cpp/autosar/test/rules/A2-10-5/IdentifierNameOfANonMemberObjectWithExternalOrInternalLinkageIsReused.expected |
Updates location coordinates for number_two template variable (column 39-48 instead of 50) and adds missing line numbers (3, 6) to test expectations |
c/misra/test/rules/RULE-14-3/test.c |
Adds line number prefix to line 45 and changes annotation from NON_COMPLIANT to NON_COMPLIANT[FALSE_NEGATIVE] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ae21fb5 to
11d0d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.