Prepare dataflow for local annotations #21138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
force-pushed
the
tausbn/python-prepare-for-overlay-annotations
branch
9 times, most recently
from
45e4b92 to
1242a7b
Compare
tausbn
force-pushed
the
tausbn/python-prepare-for-overlay-annotations
branch
8 times, most recently
from
897bbbc to
b8c0ed3
Compare
tausbn
force-pushed
the
tausbn/python-prepare-for-overlay-annotations
branch
from
b8c0ed3 to
13d118b
Compare
Removes the dependence on the (global) `ModuleVariableNode.getARead()`, by adding a local version (that doesn't include `import *` reads) instead.
This may result in more nodes, but it should still be bounded by the number of global variables in the source code.
With `ModuleVariableNode`s now appearing for _all_ global variables (not just the ones that actually seem to be used), some of the tests changed a bit. Mostly this was in the form of new flow (because of new nodes that popped into existence). For some inline expectation tests, I opted to instead exclude these results, as there was no suitable location to annotate. For the normal tests, I just accepted the output (after having vetted it carefully, of course).
Explicitly adds a bunch of nodes that were previously (using a global analysis) identified as `ExtractedArgumentNode`s. These are then subsequently filtered out in `argumentOf` (which is global) by putting the call to `getCallArg` there instead of in the charpred.
Fixes the test failures that arose from making `ExtractedArgumentNode` local. For the consistency checks, we now explicitly exclude the `ExtractedArgumentNode`s (now much more plentiful due to the overapproximation) that don't have a corresponding `getCallArg` tuple. For various queries/tests using `instanceof ArgumentNode`, we instead us `isArgumentNode`, which explicitly filters out the ones for which `isArgumentOf` doesn't hold (which, again, is the case for most of the nodes in the overapproximation).
Uses the same trick as for `ExtractedArgumentNode`, wherein we postpone the global restriction on the charpred to instead be in the `argumentOf` predicate (which is global anyway). In addition to this, we also converted `CapturedVariablesArgumentNode` into a proper synthetic node, and added an explicit post-update node for it. These nodes just act as wrappers for the function part of call nodes. Thus, to make them work with the variable capture machinery, we simply map them to the closure node for the corresponding control-flow or post-update node.
tausbn
force-pushed
the
tausbn/python-prepare-for-overlay-annotations
branch
from
13d118b to
e3579c9
Compare
As we now have many more capturing closure arguments, we must once again exclude the ones that don't actually have `argumentOf` defined.
tausbn
force-pushed
the
tausbn/python-prepare-for-overlay-annotations
branch
from
e3579c9 to
734702a
Compare
New nodes means new results. Luckily we rarely have a test that selects _all_ dataflow nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all of the changes that are needed in order to get all of the
overlay[local]annotations to compile.Reviewing on a commit-by-commit basis is highly recommended.
No change note required as these changes should not have any visible effect.