Skip to content

Comments

Revert SoftFloat Changes#21359

Merged
jketema merged 1 commit intogithub:mainfrom
jketema:jketema/softfloat-revert
Feb 24, 2026
Merged

Revert SoftFloat Changes#21359
jketema merged 1 commit intogithub:mainfrom
jketema:jketema/softfloat-revert

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Feb 24, 2026

This reverts commit 99de5d4, reversing changes made to 12bd709.

Copilot AI review requested due to automatic review settings February 24, 2026 10:14
@jketema jketema requested a review from a team as a code owner February 24, 2026 10:14
@github-actions github-actions bot added the C++ label Feb 24, 2026
@jketema jketema added depends on internal PR This PR should only be merged in sync with an internal Semmle PR and removed C++ labels Feb 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts commit 99de5d4, which introduced SoftFloat changes that affected how floating-point literals are represented in C++ test expected output files. The revert restores the previous full-precision floating-point literal representation across multiple test expectation files.

Changes:

  • Reverts floating-point literal representations from shortened format (e.g., 0.47438827, 1.0E-6) back to full-precision format (e.g., 0.4743882700000000008, 9.999999999999999547e-07)
  • Restores line numbers in test expectation files that were removed during the original SoftFloat commit
  • Affects four C++ test expected output files covering range analysis, control flow guards, and complex number builtins

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/nrOfBounds.expected Reverts floating-point literals to full precision and restores line numbers for 66 entries
cpp/ql/test/library-tests/controlflow/guards/GuardsEnsure.expected Reverts scientific notation literals (1.0E-6) to full precision format and restores 6 line numbers
cpp/ql/test/library-tests/controlflow/guards/GuardsCompare.expected Reverts scientific notation literals (1.0E-6) to full precision format and restores 4 line numbers
cpp/ql/test/library-tests/builtins/complex/builtin.expected Reverts floating-point literals for complex number constants to full precision format and restores 2 line numbers

@jketema jketema merged commit 0947323 into github:main Feb 24, 2026
16 of 17 checks passed
@jketema jketema deleted the jketema/softfloat-revert branch February 24, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on internal PR This PR should only be merged in sync with an internal Semmle PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants