Conversation
Co-authored-by: Sarita Iyer <66540150+saritai@users.noreply.github.com>
Co-authored-by: Sarita Iyer <66540150+saritai@users.noreply.github.com>
Co-authored-by: Melissa Xie <mxie@users.noreply.github.com> Co-authored-by: Joe Clark <31087804+jc-clark@users.noreply.github.com> Co-authored-by: Steve Ward <steveward@github.com>
github-actions
bot
added
the
triage
Contributor
There was a problem hiding this comment.
Pull Request Overview
This automated PR syncs changes between public and private repositories to ensure consistency across related documentation and policies. Key changes include:
- Adding an "OpenAI" entry in the GitHub subprocessors list.
- Updating commit message instructions in GitHub Desktop documentation with additional guidance and a new Copilot button.
- Incorporating new sections and bullets to describe GitHub Copilot Desktop features in copilot-related policy and feature docs.
- Adjusting upgrade instructions to modify the description of waiting for background upgrade tasks.
Reviewed Changes
Copilot reviewed 16 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| content/site-policy/privacy-policies/github-subprocessors.md | Added an "OpenAI" entry in the subprocessors table. |
| content/desktop/making-changes-in-a-branch/committing-and-reviewing-changes-to-your-project-in-github-desktop.md | Updated commit message guidance with additional steps and a new Copilot icon reference. |
| content/copilot/managing-copilot/managing-github-copilot-in-your-organization/managing-policies-for-copilot-in-your-organization.md | Added Copilot Desktop (public preview) to the policies list. |
| content/copilot/managing-copilot/managing-copilot-for-your-enterprise/managing-policies-and-features-for-copilot-in-your-enterprise.md | Added a section for Copilot Desktop and updated the enterprise policy list accordingly. |
| content/copilot/about-github-copilot/github-copilot-features.md | Introduced a new section detailing Copilot Desktop’s feature for auto-generating commit messages. |
| content/admin/upgrading-your-instance/performing-an-upgrade/upgrading-with-an-upgrade-package.md | Revised upgrade instructions to remove a fixed wait time and describe the process more generally. |
Files not reviewed (14)
- src/github-apps/data/ghec-2022-11-28/fine-grained-pat-permissions.json: Language not supported
- src/github-apps/data/ghec-2022-11-28/server-to-server-permissions.json: Language not supported
- src/github-apps/data/ghes-3.12-2022-11-28/fine-grained-pat-permissions.json: Language not supported
- src/github-apps/data/ghes-3.12-2022-11-28/server-to-server-permissions.json: Language not supported
- src/github-apps/data/ghes-3.13-2022-11-28/fine-grained-pat-permissions.json: Language not supported
- src/github-apps/data/ghes-3.13-2022-11-28/server-to-server-permissions.json: Language not supported
- src/github-apps/data/ghes-3.14-2022-11-28/fine-grained-pat-permissions.json: Language not supported
- src/github-apps/data/ghes-3.14-2022-11-28/server-to-server-permissions.json: Language not supported
- src/github-apps/data/ghes-3.15-2022-11-28/fine-grained-pat-permissions.json: Language not supported
- src/github-apps/data/ghes-3.15-2022-11-28/server-to-server-permissions.json: Language not supported
- src/github-apps/data/ghes-3.16-2022-11-28/fine-grained-pat-permissions.json: Language not supported
- src/github-apps/data/ghes-3.16-2022-11-28/server-to-server-permissions.json: Language not supported
- src/github-apps/lib/config.json: Language not supported
- src/rest/data/fpt-2022-11-28/schema.json: Language not supported
Comment on lines
+18
to
19
| If you're running back-to-back feature version upgrades, you must ensure background jobs are complete before proceeding with the following upgrade to a feature release. {% data variables.product.prodname_dotcom %} recommends waiting for any background upgrade tasks to complete before upgrading a second time. See [AUTOTITLE](/admin/upgrading-your-instance/preparing-to-upgrade/overview-of-the-upgrade-process) and [AUTOTITLE](/admin/enterprise-management/updating-the-virtual-machine-and-physical-resources/upgrade-requirements). | ||
|
|
There was a problem hiding this comment.
The revised instruction no longer specifies a fixed waiting period and may be ambiguous for operators. Consider clarifying whether a fixed wait time should be observed or provide more detailed guidance on how to determine when background upgrade tasks have completed.
Suggested change
| If you're running back-to-back feature version upgrades, you must ensure background jobs are complete before proceeding with the following upgrade to a feature release. {% data variables.product.prodname_dotcom %} recommends waiting for any background upgrade tasks to complete before upgrading a second time. See [AUTOTITLE](/admin/upgrading-your-instance/preparing-to-upgrade/overview-of-the-upgrade-process) and [AUTOTITLE](/admin/enterprise-management/updating-the-virtual-machine-and-physical-resources/upgrade-requirements). | |
| If you're running back-to-back feature version upgrades, you must ensure background jobs are complete before proceeding with the following upgrade to a feature release. To verify the completion of background tasks, use the `ghe-check-background-upgrade-jobs` utility. {% data variables.product.prodname_dotcom %} recommends waiting for any background upgrade tasks to complete before upgrading a second time. See [AUTOTITLE](/admin/upgrading-your-instance/preparing-to-upgrade/overview-of-the-upgrade-process), [AUTOTITLE](/admin/enterprise-management/updating-the-virtual-machine-and-physical-resources/upgrade-requirements), and [AUTOTITLE](/admin/configuration/configuring-your-enterprise/command-line-utilities#ghe-check-background-upgrade-jobs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos, do not squash this pull request.