Conversation
Co-authored-by: Sophie <29382425+sophietheking@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sophie <29382425+sophietheking@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request is an automated repo sync to align changes between the public and private repositories while preserving commit history. Key updates include:
- Updating the URL construction for social card images in DefaultLayout.tsx.
- Modifying the Azure entry in the GitHub subprocessors markdown file to include AI Inference.
- Revising the Docker dependency option comment in the Dependabot options reference.
Reviewed Changes
Copilot reviewed 3 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frame/components/DefaultLayout.tsx | Updated URL generation for social card images with a conditional protocol based on xHost. |
| content/site-policy/privacy-policies/github-subprocessors.md | Updated Azure entry description with additional details on AI Inference. |
| content/code-security/dependabot/working-with-dependabot/dependabot-options-reference.md | Amended Docker dependency comment from Ruby version syntax to Bundler version syntax. |
Files not reviewed (10)
- src/github-apps/lib/config.json: Language not supported
- src/rest/data/fpt-2022-11-28/schema.json: Language not supported
- src/rest/data/ghec-2022-11-28/schema.json: Language not supported
- src/rest/data/ghes-3.12-2022-11-28/schema.json: Language not supported
- src/rest/data/ghes-3.13-2022-11-28/schema.json: Language not supported
- src/rest/data/ghes-3.14-2022-11-28/schema.json: Language not supported
- src/rest/data/ghes-3.15-2022-11-28/schema.json: Language not supported
- src/rest/data/ghes-3.16-2022-11-28/schema.json: Language not supported
- src/rest/lib/config.json: Language not supported
- src/webhooks/lib/config.json: Language not supported
Comments suppressed due to low confidence (2)
src/frame/components/DefaultLayout.tsx:64
- Consider verifying that xHost does not already include a protocol (e.g., 'https://') before prepending 'https://', to avoid potential duplication in the URL. A simple check or normalization function could improve the robustness of the URL construction.
const SOCIAL_CARD_IMG_BASE_URL = `${xHost ? 'https://' + xHost : ''}/assets/cb-345/images/social-cards`
content/code-security/dependabot/working-with-dependabot/dependabot-options-reference.md:279
- Ensure that the change from Ruby version syntax to Bundler version syntax for Docker is clearly documented and consistent with the current official documentation guidelines for handling Docker dependency options.
* Docker: use Bundler version syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos, do not squash this pull request.