Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR converts the test suite from Karma/Mocha to Vitest, modernizing the testing infrastructure for better developer experience and faster test execution.
Key changes:
- Replaced Karma/Mocha test runner with Vitest
- Updated test assertions from
asserttoexpectsyntax - Modernized Node.js version to 18 in CI workflows
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | New Vitest configuration with happy-dom environment and global test functions |
| test/setup.ts | Test setup file with polyfills and custom element registration for Vitest |
| test/attachment.test.ts | Converted test file from Mocha/assert to Vitest/expect syntax |
| test/.eslintrc.json | Removed Mocha-specific ESLint configuration |
| package.json | Updated scripts and dependencies to use Vitest instead of Karma |
| .github/workflows/publish.yml | Updated Node.js version from 14 to 18 |
| .github/workflows/nodejs.yml | Updated Node.js version and workflow structure |
| .eslintignore | Added test setup file to ignore list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
|
||
| // Polyfill for DataTransfer if needed (based on test environment) | ||
| if (typeof DataTransfer === 'undefined') { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Using @ts-ignore suppresses TypeScript errors without explanation. Consider using @ts-expect-error with a comment explaining why this is necessary, or properly type the global declaration.
Suggested change
| // @ts-ignore |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.