Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes loss of underlying GraphQL query errors in fetchIssueIDs, improving diagnostics for callers (notably update_issue when closing/reopening issues via GraphQL).
Changes:
- Wrap GraphQL client query errors with
%winfetchIssueIDs(both single-ID and dual-ID query paths), preserving the root cause for downstream error reporting.
omgitsads
approved these changes
Mar 5, 2026
kristentr
added a commit
to kristentr/github-mcp-server
that referenced
this pull request
Mar 5, 2026
* Stricter matching for github.com and ghe.com URLs * Gracefully handle numeric parameters passed as strings (github#2130) * Gracefully handle numeric parameters passed as strings * Fix SHA validation in create_or_update_file (github#2134) * Fix SHA validation in create_or_update_file * Doc update * Handle non-404 errors * Handle directory paths * Update instructions * fix: handle empty files in get_file_contents (github#2042) 1. Empty (0-byte) files caused an unhandled error because the GitHub API returns null content with base64 encoding for them; GetContent() fails with "malformed response: base64 encoding of null content". Return empty text/plain content directly, bypassing decoding entirely. Co-authored-by: Ksenia Bobrova <almaleksia@github.com> * Cline & Roo code installation guides (github#2146) * Cline & Roo code installation guides * Update docs/installation-guides/install-cline.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Correctly wrap GraphQl error (github#2149) --------- Co-authored-by: Ksenia Bobrova <almaleksia@github.com> Co-authored-by: Jakub Janusz <32165716+kubajanusz@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We shouldn't drop error returned by graphql client in
fetchIssueIDsWhy
Fixes #2067
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs