Refactor content type check for response handling#110
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the response handling logic in the include-fragment element to check content type before HTTP status code. Previously, content type errors were being masked by status code errors because responses with incorrect content types (like 406 status) were caught by the status check first.
- Reordered content type validation to occur before status code validation
- Updated test assertions to reflect the new error message precedence
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/include-fragment-element.ts | Moved content type check before status code check in response handling |
| test/test.js | Updated test assertions to expect content type error messages instead of status code errors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
francinelucca
approved these changes
Sep 3, 2025
manuelpuyol
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/primer/issues/5409
This moves the content type error check to before the
status !== 200check. The content type one was never getting hit because it was passing406as a status code and getting caught by the not 200 check.