Change recommended vim keybinding for "reset file"#2853
Open
callpraths wants to merge 1 commit intogitui-org:masterfrom
Open
Change recommended vim keybinding for "reset file"#2853callpraths wants to merge 1 commit intogitui-org:masterfrom
callpraths wants to merge 1 commit intogitui-org:masterfrom
Conversation
9e22210 to
02776a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2704
Avoids a hindenbug due to two interpretations of
Shift+Uvim-style bindingsThere is a potential for confusion between those two actions and they have qualitatively different outcomes - the default binding is more of a user-data destroying action (though there's always
reflog...)This PR updates the suggested
vimbinding to lowercaseu. This makesuthe keybinding for:Those two actions have the same scope - undo unstaged changes in working directory, so having the same key-binding makes sense.
I followed the checklist:
make checkwithout errors