Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/com/google/adk/agents/LlmAgent.java
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,10 @@ private Model resolveModelInternal() {
Model currentModel = this.model.get();

if (currentModel.model().isPresent()) {
return currentModel;
String modelName = currentModel.model().get().model();
BaseLlm resolvedLlm = currentModel.model().get();

return Model.builder().modelName(modelName).model(resolvedLlm).build();
}

if (currentModel.modelName().isPresent()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ private static List<Event> rearrangeEventsForAsyncFunctionResponsesInHistory(

// Gemini 3 requires function calls to be grouped first and only then function responses:
// FC1 FC2 FR1 FR2
boolean shouldBufferResponseEvents = modelName.startsWith("gemini-3-");
boolean shouldBufferResponseEvents = modelName.contains("gemini-3-");

for (int i = 0; i < events.size(); i++) {
Event event = events.get(i);
Expand Down
11 changes: 11 additions & 0 deletions core/src/test/java/com/google/adk/agents/LlmAgentTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,17 @@ public void resolveModel_withModelName_resolvesFromRegistry() {
assertThat(resolvedModel.model()).hasValue(testLlm);
}

@Test
public void resolveModel_withModel_usesProvidedModel() {
TestLlm testLlm = createTestLlm(LlmResponse.builder().build());
LlmAgent testAgent = createTestAgent(testLlm);

Model resolvedModel = testAgent.resolvedModel();

assertThat(resolvedModel.model()).hasValue(testLlm);
assertThat(resolvedModel.modelName()).hasValue(testLlm.model());
}

@Test
public void canonicalCallbacks_returnsEmptyListWhenNull() {
TestLlm testLlm = createTestLlm(LlmResponse.builder().build());
Expand Down