refactor: Simplifying State interfaces#892
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
refactor: Simplifying State interfaces#892copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This is really two changes: 1. Replace the interface of state from ConcurrentMap to Map 2. Under the covers use extenral synchornization (Collections.synchronize, etc) along with HashMap wich allows nulls to represent "remove this variable from the session" This devX improvement comes with a subtle assumption that State will be passed in as a HashMap. This change may cause subtle breaking changes. PiperOrigin-RevId: 872418434
copybara-service
bot
force-pushed
the
test_872418434
branch
from
475c3d3 to
5dcfc68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Simplifying State interfaces
This is really two changes:
This devX improvement comes with a subtle assumption that State will be passed in as a HashMap. This change may cause subtle breaking changes.