chore: Use example.com instead of random URLs in tests#3948
chore: Use example.com instead of random URLs in tests#3948gmlewis merged 3 commits intogoogle:masterfrom
example.com instead of random URLs in tests#3948Conversation
|
@gmlewis Should I update them too? This test contain some download URLs go-github/github/actions_runners_test.go Lines 33 to 38 in 1c42933 The URL present in this test go-github/github/admin_users_test.go Lines 124 to 128 in 1c42933 The URLs present in this test Lines 28 to 50 in 1c42933 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3948 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 203 203
Lines 14980 14980
=======================================
Hits 13850 13850
Misses 927 927
Partials 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
example.com instead of random URLs in testexample.com instead of random URLs in tests
|
@Not-Dhananjay-Mishra - I think that IP addresses (since there is no particular reason to use IP addresses in this case that I can tell) can be changed to example.com and so can git.company.com. Thanks. |
|
This PR is ready for review 😸. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
Thank you, @alexandear! |
For reference : comment