Skip to content

chore: Use example.com instead of random URLs in tests#3948

Merged
gmlewis merged 3 commits intogoogle:masterfrom
Not-Dhananjay-Mishra:example
Feb 1, 2026
Merged

chore: Use example.com instead of random URLs in tests#3948
gmlewis merged 3 commits intogoogle:masterfrom
Not-Dhananjay-Mishra:example

Conversation

@Not-Dhananjay-Mishra
Copy link
Contributor

For reference : comment

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra marked this pull request as draft January 29, 2026 14:56
@Not-Dhananjay-Mishra
Copy link
Contributor Author

@gmlewis Should I update them too?

This test contain some download URLs

want := []*RunnerApplicationDownload{
{OS: Ptr("osx"), Architecture: Ptr("x64"), DownloadURL: Ptr("https://github.com/actions/runner/releases/download/v2.164.0/actions-runner-osx-x64-2.164.0.tar.gz"), Filename: Ptr("actions-runner-osx-x64-2.164.0.tar.gz")},
{OS: Ptr("linux"), Architecture: Ptr("x64"), DownloadURL: Ptr("https://github.com/actions/runner/releases/download/v2.164.0/actions-runner-linux-x64-2.164.0.tar.gz"), Filename: Ptr("actions-runner-linux-x64-2.164.0.tar.gz")},
{OS: Ptr("linux"), Architecture: Ptr("arm"), DownloadURL: Ptr("https://github.com/actions/runner/releases/download/v2.164.0/actions-runner-linux-arm-2.164.0.tar.gz"), Filename: Ptr("actions-runner-linux-arm-2.164.0.tar.gz")},
{OS: Ptr("win"), Architecture: Ptr("x64"), DownloadURL: Ptr("https://github.com/actions/runner/releases/download/v2.164.0/actions-runner-win-x64-2.164.0.zip"), Filename: Ptr("actions-runner-win-x64-2.164.0.zip")},
{OS: Ptr("linux"), Architecture: Ptr("arm64"), DownloadURL: Ptr("https://github.com/actions/runner/releases/download/v2.164.0/actions-runner-linux-arm64-2.164.0.tar.gz"), Filename: Ptr("actions-runner-linux-arm64-2.164.0.tar.gz")},

The URL present in this test

want := &UserAuthorization{
ID: Ptr(int64(1234)),
URL: Ptr("https://git.company.com/api/v3/authorizations/1234"),
App: &OAuthAPP{
Name: Ptr("GitHub Site Administrator"),

The URLs present in this test

ActionsMacos: []string{"192.0.2.1/32", "198.51.100.0/24"},
Dependabot: []string{"d"},
SSHKeyFingerprints: map[string]string{"a": "f"},
SSHKeys: []string{"k"},
API: []string{"a"},
Web: []string{"w"},
Domains: &APIMetaDomains{
Website: []string{
"*.github.com",
"*.github.dev",
"*.github.io",
"*.githubassets.com",
"*.githubusercontent.com",
},
ArtifactAttestations: &APIMetaArtifactAttestations{
TrustDomain: "",
Services: []string{
"*.actions.githubusercontent.com",
"tuf-repo.github.com",
"fulcio.githubapp.com",
"timestamp.githubapp.com",
},
},

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (096e4ce) to head (889c100).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3948   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         203      203           
  Lines       14980    14980           
=======================================
  Hits        13850    13850           
  Misses        927      927           
  Partials      203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title chore: Use of example.com instead of random URLs in test chore: Use example.com instead of random URLs in tests Jan 30, 2026
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 30, 2026

@Not-Dhananjay-Mishra - I think that https://github.com/actions/runner can be left alone since it is a real repo on GitHub relevant to action runner.

IP addresses (since there is no particular reason to use IP addresses in this case that I can tell) can be changed to example.com and so can git.company.com.

Thanks.

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra marked this pull request as ready for review January 31, 2026 05:29
@Not-Dhananjay-Mishra
Copy link
Contributor Author

This PR is ready for review 😸.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 1, 2026
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 1, 2026

Thank you, @alexandear!
Merging.

@gmlewis gmlewis merged commit d1dd1a5 into google:master Feb 1, 2026
8 checks passed
@Not-Dhananjay-Mishra Not-Dhananjay-Mishra deleted the example branch February 1, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants