chore: Address otel review feedback#3969
Merged
gmlewis merged 1 commit intogoogle:masterfrom Feb 5, 2026
Merged
Conversation
5b0bb6c to
7fe9be0
Compare
gmlewis
reviewed
Feb 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3969 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 206 206
Lines 17550 17550
=======================================
Hits 16411 16411
Misses 938 938
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Feb 5, 2026
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example/go.modinstead ofexample/otel/go.modfor consistency with other examples.go.opentelemetry.iopackages.oteldirectory.Follows #3938