fix!: CreateHostedRunnerRequest, UpdateHostedRunnerRequest instead of HostedRunnerRequest

[alexandear]

BREAKING CHANGE: ActionsService.CreateHostedRunner and EnterpriseService.CreateHostedRunner now accept CreateHostedRunnerRequest; ActionsService.UpdateHostedRunner and EnterpriseService.UpdateHostedRunner now accept UpdateHostedRunnerRequest.

---

While working on #3972, I found that ActionsService.UpdateHostedRunner accepts HostedRunnerRequest as a body. But it's wrong according to the docs for actions and enterprise.

Current:

type HostedRunnerRequest struct {
	Name           string            `json:"name,omitempty"`
	Image          HostedRunnerImage `json:"image,omitempty"`
	RunnerGroupID  int64             `json:"runner_group_id,omitempty"`
	Size           string            `json:"size,omitempty"`
	MaximumRunners int64             `json:"maximum_runners,omitempty"`
	EnableStaticIP bool              `json:"enable_static_ip,omitempty"`
	ImageVersion   string            `json:"image_version,omitempty"`
}

Should be image_id (optional) instead of the Image. So, I created a separate struct UpdateHostedRunnerRequest with an optional image_id and the rest of the fields (all optional).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (3260322) to head (ae9b930).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3973   +/-   ##
=======================================
  Coverage   93.52%   93.53%           
=======================================
  Files         207      207           
  Lines       17600    17586   -14     
=======================================
- Hits        16461    16449   -12     
+ Misses        938      937    -1     
+ Partials      201      200    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

So HostedRunnerRequest has both image_version and image.version? That seems odd.

In other parts of this repo, we reuse structs and add comments for fields that are used by one endpoint and not another... so are you thinking that splitting this struct into two separate use cases is going to reduce end-user confusion, and therefore is a desirable change?

[alexandear]

We can't reuse structs in this case. They are different. And yes, splitting this struct into two separate use cases:

1. fixes Update methods.
2. reduces end-user confusion (optional-required fields).

Here are comparison with Copilot:

Field	Create	Update	Required in Create	Required in Update
name	✓	✓	Required	Optional
image (object with id and source)	✓	-	Required	-
size	✓	✓	Required	Optional
runner_group_id	✓	✓	Required	Optional
maximum_runners	✓	✓	Optional	Optional
enable_static_ip	✓	✓	Optional	Optional
image_gen	✓	-	Optional (default: false)	-
image_id	-	✓	-	Optional
image_version	-	✓	-	Optional (can be null)

Raw doc screenshots

Create body:

Update body:

[gmlewis]

Thank you, @alexandear!
One nit, otherwise LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[Not-Dhananjay-Mishra]

LGTM

[gmlewis]

Thank you, @Not-Dhananjay-Mishra!
Merging.