feat(storage): adding logging decorator for object_descriptor_connection#15331
Open
shubham-up-47 wants to merge 19 commits intogoogleapis:mainfrom
Open
feat(storage): adding logging decorator for object_descriptor_connection#15331shubham-up-47 wants to merge 19 commits intogoogleapis:mainfrom
shubham-up-47 wants to merge 19 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15331 +/- ##
==========================================
+ Coverage 93.02% 93.03% +0.01%
==========================================
Files 2403 2409 +6
Lines 219441 219955 +514
==========================================
+ Hits 204139 204645 +506
- Misses 15302 15310 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/gcbrun |
Contributor
|
@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR? |
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding logging decorator for object_descriptor_connection which creates logical logs for the Read() operations created by the application (#15141).
Currently this pattern is followed for otel tracing,
Following the same pattern for creating the logging decorator,
This change is