Skip to content

ci: add trap function to look for core files #15919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 1 commit into from
Jan 29, 2026
+8 −2
Merged

ci: add trap function to look for core files #15919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ci/cloudbuild/builds/lib/quickstart.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ source module ci/cloudbuild/builds/lib/cmake.sh
source module ci/etc/quickstart-config.sh
source module ci/lib/io.sh

function cleanup() {
local exit_status=$?
io::log_h2 "cleanup on EXIT with exit_status=${exit_status}"
io::run find . -name '*core*'
}
Comment on lines +34 to +38
Copy link

@gemini-code-assist gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The cleanup function, when triggered by the EXIT trap, will cause the script to exit with the status of the last command it runs (io::run find ...), which is likely 0. This can mask the original exit status of the script if it was failing. To preserve the original exit status, the trap handler should ensure it exits with that status.

Suggested change
function cleanup() {
local exit_status=$?
io::log_h2 "cleanup on EXIT with exit_status=${exit_status}"
io::run find . -name '*core*'
}
function cleanup() {
local exit_status=$?
io::log_h2 "cleanup on EXIT with exit_status=${exit_status}"
io::run find . -name '*core*'
(exit "${exit_status}")
}


trap 'cleanup' INT TERM EXIT

# Builds the CMake and Makefile quickstart programs but DOES NOT RUN THEM. This
# is a useful way to test that the artifacts installed by `google-cloud-cpp`
# work for compilation. This function requires a single argument specifying the
Expand Down Expand Up @@ -97,8 +105,6 @@ function quickstart::run_cmake_and_make() {
mapfile -t run_args < <(quickstart::arguments "${lib}")
quickstart::run_one_quickstart "${prefix}" "${lib}" "${run_args[@]}"
done

io::run find . -name '*core*'
}

function quickstart::run_gcs_grpc_quickstart() {
Expand Down
Loading