-
Notifications
You must be signed in to change notification settings - Fork 324
chore: replace old python teams with cloud-sdk-python-team #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration files to reflect a change in the designated Python team. The primary goal is to transition all automated assignments and ownership declarations from an older team identifier to a new, consolidated cloud SDK Python team. This change streamlines the workflow for code reviews, issue management, and general repository maintenance by ensuring that the correct team is engaged for relevant tasks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the python team names across several configuration files, replacing @googleapis/python-core-client-libraries and potentially other teams with @googleapis/cloud-sdk-python-team. The changes in .github/blunderbuss.yml and .repo-metadata.json are correct. However, in .github/CODEOWNERS, this replacement has resulted in the new team being listed twice on two separate lines. I've added suggestions to remove these redundant entries for better clarity and maintenance.
.github/CODEOWNERS
Outdated
| # The @googleapis/python-core-client-libraries is the default owner for changes in this repo | ||
| * @googleapis/python-core-client-libraries @googleapis/yoshi-python | ||
| # The @googleapis/cloud-sdk-python-team is the default owner for changes in this repo | ||
| * @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| # The python-samples-reviewers team is the default owner for samples changes | ||
| /samples/ @googleapis/python-core-client-libraries @googleapis/python-samples-owners @googleapis/yoshi-python | ||
| /samples/ @googleapis/cloud-sdk-python-team @googleapis/python-samples-owners @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
179c19e to
b230c0e
Compare
Bug ID: b/479543683