add a configurable reconnect option for websocket#434
Merged
jmattheis merged 4 commits intogotify:masterfrom Feb 13, 2026
Merged
add a configurable reconnect option for websocket#434jmattheis merged 4 commits intogotify:masterfrom
jmattheis merged 4 commits intogotify:masterfrom
Conversation
Member
|
FYI: I'm currently a little busy and my android testing setup broke. I'll try to review this this or next week. |
jmattheis
reviewed
Feb 13, 2026
Comment on lines
+32
to
+33
| private val reconnectDelay: Duration, | ||
| private val exponentialBackoff: Boolean |
Member
There was a problem hiding this comment.
I've made some changes
- used Durations everwhere
- renamed interval to delay
- added exponential backoff
- inversed the constant retry interval setting
jmattheis
approved these changes
Feb 13, 2026
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 2 options to control the way the websocket reconnects when it fails: