Add support for long press functionality.#39
Add support for long press functionality.#39scarfex wants to merge 2 commits intohimelbrand:masterfrom
Conversation
himelbrand
left a comment
himelbrand
left a comment
There was a problem hiding this comment.
Thanks @scarfex,
I reviewed your PR and I added comments on little cosmetic changes that need to be made.
| } | ||
|
|
||
| startInc = () => {this.inc(); this.incInterval = setInterval(this.inc, 100); } | ||
| startDec = () => {this.dec(); this.decInterval = setInterval(this.dec, 100); } |
There was a problem hiding this comment.
please change them to be spread on a few lines, like the other functions, please
There was a problem hiding this comment.
since they have more than one command
also please remove the semicolon from the end of lines, please
| } | ||
|
|
||
| stopInc = () => { | ||
|
|
| } | ||
|
|
||
| stopDec = () => { | ||
|
|
|
|
||
| stopDec = () => { | ||
|
|
||
| clearInterval(this.decInterval); |
|
|
||
| stopInc = () => { | ||
|
|
||
| clearInterval(this.incInterval); |
|
also, I just noticed that the PR is into the master branch. |
|
@scarfex until you make the requested changes the PR won't be approved. |
|
This would be a nice addition, @scarfex please implement the small changes so we can enjoy it |
3 participants
Found a way to change values quicker with a long press of the increase or decrease buttons.