Enable styles for buttons as well as enable disabling and enabling buttons#66
Open
Monir-Shembesh wants to merge 6 commits intohimelbrand:masterfrom
Open
Enable styles for buttons as well as enable disabling and enabling buttons#66Monir-Shembesh wants to merge 6 commits intohimelbrand:masterfrom
Monir-Shembesh wants to merge 6 commits intohimelbrand:masterfrom
Conversation
Owner
|
Cool, thanks! |
Owner
|
Thanks a lot for your contribution! |
Author
|
Hi, yes please merge it i have updated the README, revised the code, as well as fixed a typo in the types file. |
Author
|
@himelbrand can you please merge this pull request? |
Owner
|
I'll review it this weekend, I missed the notification sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the hassle of making one pull request to all features, but thought it would make sense.
I am currently working on a project and found out that I need to disable the
incrementanddecrementbuttons when the user reaches themaxorminvalues specified.Therefore, the following was done:
1- add expected props to the
typescript interfacefollowing a previous name convention used with the icon styles2- change the
styleprop on theincrementanddecrementto be an array3- spread the upcoming props that are related to the button styles if
trueother wise just use{}4- add a
disabledprop to the buttons5- write a condition inside the disabled prop that checks if the max/min reached as well if the user passed the disablers props
disableIncButtonOnMaxReachanddisableDecButtonOnMaxReachHappy to make any necessary changes after reviewing