Move all CDATA section tests into one file#170
Open
not-my-profile wants to merge 1 commit intohtml5lib:masterfrom
Open
Move all CDATA section tests into one file#170not-my-profile wants to merge 1 commit intohtml5lib:masterfrom
not-my-profile wants to merge 1 commit intohtml5lib:masterfrom
Conversation
All other initial states are referenced outside the section 13.2.5 Tokenization[1] that describes the tokenizer state machine. It's therefore reasonable to consider the 'CDATA section state' an implementation detail and as such a tokenizer may choose to avoid exposing it in it's public API. In that scenario while all other tests could be integration tests that solely use the public API, the tests for the 'CDATA section state' would need to be performed internally rather than externally. This commit moves all the 'CDATA section state' tests into a new separate cdataSection.test file to faciliate such testing. [1]: https://html.spec.whatwg.org/multipage/parsing.html#tokenization
Contributor
|
To be clear, given that there's only a very high-level public API defined, most things are probably implementation details. Seems reasonable to move things around though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other initial states are referenced outside the section 13.2.5 Tokenization1 that describes the tokenizer state machine.
It's therefore reasonable to consider the 'CDATA section state' an implementation detail and as such a tokenizer may choose to avoid exposing it in it's public API.
In that scenario while all other tests could be integration tests that solely use the public API, the tests for the 'CDATA section state' would need to be performed internally rather than externally.
This commit moves all the 'CDATA section state' tests into a new separate cdataSection.test file to faciliate such testing.