Refactor: Use Android KTX extensions#36
Merged
pimterry merged 2 commits intohttptoolkit:mainfrom Sep 12, 2025
Merged
Conversation
|
|
- Replace `View.visibility` with `View.isVisible`
- Replace `Uri.parse(String)` with `String.toUri()`
- Replace `SharedPreferences.edit().*().apply()` with `SharedPreferences.edit { *() }`
- Use `JSONPropertyName` for `published_at` and `tag_name` fields in `GithubRelease`
- Update `getInstallerPackageName` to use `getInstallSourceInfo` for Android R and above
WiMank
force-pushed
the
ref-code-and-style
branch
from
5963c3c to
404e0c2
Compare
Use Klaxon's @JSON annotation to map JSON keys to field names.
pimterry
approved these changes
Sep 12, 2025
Member
|
Nice work, thanks @WiMank! In case you're not aware, HTTP Toolkit Pro is free for all contributors - I've just activated that for the email from your git commits, just click 'Get Pro' then 'Log into existing account' in HTTP Toolkit and enter your email to get started. |
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Member
|
Don't worry about the above @WiMank - that's an existing issue which isn't related to this, not sure why Sentry is picking it up (and honestly, not sure why Sentry is actively commenting at all - must be a new feature, I've now turned that off). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the codebase to leverage Android KTX extensions for more idiomatic Kotlin code.
Specific changes include:
String.toUri()forUriparsing.SharedPreferences.edit { ... }for simplified SharedPreferences editing.View.isVisiblefor managing view visibility.getInstallerPackageNameusage togetInstallSourceInfofor Android R and above.