Bugfix: Context Parallel crash when seq-len not divisible by mesh size#12988
Open
tsu-bin wants to merge 1 commit intohuggingface:mainfrom
Open
Bugfix: Context Parallel crash when seq-len not divisible by mesh size#12988tsu-bin wants to merge 1 commit intohuggingface:mainfrom
tsu-bin wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Context Parallel implementation of diffusers can't handle the case that sequence length not divisible by mesh size. This issue is universal for all models. Now take Qwen-Image as an example, before this PR:
The design of this bugfix is rather simple, yet robust and performant: