-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Modular]add a real quick start guide #13029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
stevhliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice and easier to start with!
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
sayakpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very cool rewrite!
| @@ -12,333 +12,250 @@ specific language governing permissions and limitations under the License. | |||
|
|
|||
| # Quickstart | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its probably ok to keep an intro in both. you can have a more detailed one in overview.md and keep it brief in the quickstart
| dd_auto_blocks = SequentialPipelineBlocks.from_blocks_dict(DIFFDIFF_AUTO_BLOCKS) | ||
| dd_pipeline = dd_auto_blocks.init_pipeline("YiYiXu/modular-demo-auto", collection="diffdiff") | ||
| dd_pipeline.load_components(torch_dtype=torch.float16) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strongly opinionated but we could also add the example of prompt upsampling that uses Gemini. This might inspire users to explore a combination of open and closed models -- something that is made quite seamless with Modular.
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
…ks vs sub-blocks etc
some of the workflow stuff is not yet support in main, this is the PR #13028