CS0436 \ConcurrentHashSet\src\ConcurrentHashSet\NullableAttributes.cs…#17
Open
huster-songtao wants to merge 2 commits intoi3arnon:mainfrom
Open
CS0436 \ConcurrentHashSet\src\ConcurrentHashSet\NullableAttributes.cs…#17huster-songtao wants to merge 2 commits intoi3arnon:mainfrom
huster-songtao wants to merge 2 commits intoi3arnon:mainfrom
Conversation
… 中的类型“MaybeNullWhenAttribute”与“System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a”中的导入类型“MaybeNullWhenAttribute”冲突。请使用 ConcurrentHashSet\src\ConcurrentHashSet\NullableAttributes.cs 中定义的类型。 ConcurrentHashSet (net6) D:\github\ConcurrentHashSet\src\ConcurrentHashSet\ConcurrentHashSet.cs Microsoft.SourceLink.GitHub use 1.1.1 version. Delete NullableAttributes.cs Support netstandard2.1 and net6 use namespace System.Collections.Concurrent
…tal:127. time elapsed 7 ms ConcurrentHashSet: stopwords_en_nltk.txt load as parallel finished, Count:127, total:127. time elapsed 78 ms ConcurrentBag: stopwords_en_nltk.txt load as parallel finished, Count:127, total:127. time elapsed 3 ms
Owner
|
Hi, I'm not really sure what this PR is trying to achieve. Also,
The
Why? there's no reason to target netstandard 2.1 as this isn't using any 2.1 features. And
This is .NET's namespace, which can't be used as this is an OSS library outside of .NET. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 中的类型“MaybeNullWhenAttribute”与“System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a”中的导入类型“MaybeNullWhenAttribute”冲突。请使用 ConcurrentHashSet\src\ConcurrentHashSet\NullableAttributes.cs 中定义的类型。 ConcurrentHashSet (net6) D:\github\ConcurrentHashSet\src\ConcurrentHashSet\ConcurrentHashSet.cs
Microsoft.SourceLink.GitHub use 1.1.1 version.
Delete NullableAttributes.cs
Support netstandard2.1 and net6
use namespace System.Collections.Concurrent