Add check for invalid use of multiple scheduler types#2293
Closed
orjandh wants to merge 1 commit intoionic-team:mainfrom
Closed
Add check for invalid use of multiple scheduler types#2293orjandh wants to merge 1 commit intoionic-team:mainfrom
orjandh wants to merge 1 commit intoionic-team:mainfrom
Conversation
Member
|
As part of our effort to keep Capacitor’s backlog healthy and aligned with current development, pull requests older than 12 months are being closed during this cleanup initiative. More context: If you’d like to pursue this change, please open a new PR against the current main branch and we’ll review it in the context of the latest codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for invalid use of multiple scheduler types in the capacitor-local-notifications plugin. I think this is a good idea as the scheduler types are checked in an arbitrary order and it might not be clear from a developers side what would happen. I decided to handle the error in similar style as the rest of the function for the respective platform.
I also noticed the handling of the scheduled time being after current time check is handled with an exception on ios, but on android it is handled by exiting out of the function and logging an error, which seems inconsistent.