Moved definitions of K and V outside of TYPE_CHECKING condition#935
Merged
Carreau merged 1 commit intoipython:mainfrom Feb 25, 2026
Merged
Moved definitions of K and V outside of TYPE_CHECKING condition#935Carreau merged 1 commit intoipython:mainfrom
Carreau merged 1 commit intoipython:mainfrom
Conversation
JohanMabille
force-pushed
the
type_var
branch
2 times, most recently
from
b9bb252 to
472a581
Compare
JohanMabille
force-pushed
the
type_var
branch
from
472a581 to
da887bf
Compare
Contributor
Author
|
The failure on PyPy is fixed in #936 |
Carreau
reviewed
Feb 25, 2026
| # This is required to avoid warnings about unresolved references when generating | ||
| # the documentation of downstream projects. | ||
| K = TypeVar("K") | ||
| V = TypeVar("V") |
Member
There was a problem hiding this comment.
I wonder if we can just dedent the K,V definition from the if block, but it does not matter much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
WARNING: Cannot resolve forward reference in type annotations of "jupyter_client.consoleapp.Dict": name 'K' is not defined [sphinx_autodoc_typehints.forward_referencethat we got when generating thejupyter_clientdocumentation (see this PR).