Open
Conversation
Contributor
Author
|
wait what the hell is this when did I do this |
Member
Idk bruh you were supposed to finish this awhile ago or something. |
iostpa
requested changes
Mar 5, 2026
Member
iostpa
left a comment
iostpa
left a comment
There was a problem hiding this comment.
The approve checks section may need to be rewritten since most PRs are ran by default, it will only be required to approve checks if the GitHub account is new
| 1. The website has no preview provided *and* isn't accessible. We expect previews for *all* webpages. | ||
| 2. The checkbox stating the user's agreement to our ToS has not been checked. | ||
| 3. The PR is requesting NS records without a valid reason or without a reason provided at all. See [this page](https://docs.is-a.dev/faq/#who-can-use-ns-records) for details on what we consider a valid reason to request NS records. | ||
| 4. The user violates our ToS in any way; e.g., if they are under thirteen years of age, if their webpage is breaking the law or hosting illegal content, cryptocurrency mining sites or tools, mass unsolicited emailing, impersonation without consent, et cetera. |
Member
There was a problem hiding this comment.
I haven't seen the unsolicited emailing on the ToS recently so not sure if it should be removed from here
Member
A month or so after the PR was made he left the maintainer team and this PR was just existing |
Co-authored-by: iostpa <iostpa@iostpa.com>
Co-authored-by: iostpa <iostpa@iostpa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A document to ease and guide new (and old) maintainers into understanding the pull request reviewing process in is-a.dev.