Skip to content

fix regression that disabled custom fpp color format in some platforms #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaRnMcDonuts merged 2 commits into from
Feb 28, 2026
Merged

fix regression that disabled custom fpp color format in some platforms #2623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0564e0
fix regression that disabled custom fpp color format in some platforms
riccardobl Feb 21, 2026
b1bba00
fix the fix
riccardobl Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions jme3-core/src/main/java/com/jme3/post/FilterPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public class FilterPostProcessor implements SceneProcessor, Savable {
private boolean multiView = false;
private AppProfiler prof;

private Format fbFormat = Format.RGB111110F;
private Format fbFormat = null;
private Format depthFormat = Format.Depth;

/**
Expand Down Expand Up @@ -206,13 +206,16 @@ public void initialize(RenderManager rm, ViewPort vp) {
}

// Determine optimal framebuffer format based on renderer capabilities
if (!renderer.getCaps().contains(Caps.PackedFloatTexture)) {
if (renderer.getCaps().contains(Caps.FloatColorBufferRGB)) {
fbFormat = Format.RGB16F;
} else if (renderer.getCaps().contains(Caps.FloatColorBufferRGBA)) {
fbFormat = Format.RGBA16F;
} else {
fbFormat = Format.RGB8;
if (fbFormat == null) {
fbFormat = Format.RGB111110F;
if (!renderer.getCaps().contains(Caps.PackedFloatTexture)) {
if (renderer.getCaps().contains(Caps.FloatColorBufferRGB)) {
fbFormat = Format.RGB16F;
} else if (renderer.getCaps().contains(Caps.FloatColorBufferRGBA)) {
fbFormat = Format.RGBA16F;
} else {
fbFormat = Format.RGB8;
}
}
}

Expand All @@ -231,11 +234,11 @@ public void initialize(RenderManager rm, ViewPort vp) {
}

/**
* Returns the default color buffer format used for the internal rendering
* passes of the filters. This format is determined during initialization
* based on the renderer's capabilities.
* Returns the default color buffer format used for the internal rendering passes of the filters. This
* format is determined during initialization based on the renderer's capabilities.
*
* @return The default `Format` for the filter pass textures.
* @return The default `Format` for the filter pass textures or null if set to be determined
* automatically.
*/
public Format getDefaultPassTextureFormat() {
return fbFormat;
Expand Down Expand Up @@ -701,10 +704,11 @@ public void setAssetManager(AssetManager assetManager) {
}

/**
* Sets the preferred `Image.Format` to be used for the internal frame buffer's
* color buffer.
* Sets the preferred `Image.Format` to be used for the internal frame buffer's color buffer.
*
* @param fbFormat The desired `Format` for the color buffer.
* @param fbFormat
* The desired `Format` for the color buffer or null to let the processor determine the optimal
* format based on renderer capabilities.
*/
public void setFrameBufferFormat(Format fbFormat) {
this.fbFormat = fbFormat;
Expand Down