respect args passed through cli conan cmds#3378
Open
reshmifrog wants to merge 3 commits intojfrog:masterfrom
Open
respect args passed through cli conan cmds#3378reshmifrog wants to merge 3 commits intojfrog:masterfrom
reshmifrog wants to merge 3 commits intojfrog:masterfrom
Conversation
reshmifrog
added
improvement
reshmifrog
added
safe to test
reshmifrog
added
safe to test
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Problem:
When running conan install --requires zlib/1.2.11 (without a conanfile.py or conanfile.txt), the JFrog CLI fails with the error "no conanfile.py or conanfile.txt found" because the build-info collection logic always expects a recipe file to exist, even though Conan 2.x officially supports installing dependencies directly via --requires and --tool-requires without any conanfile.
Solution:
Modified loadConanfile() in build-info-go to gracefully set default project metadata (name from directory, empty version, default user/channel) instead of failing when no conanfile is found. Updated buildGraphInfoArgs() to pass --requires and --tool-requires flags directly to conan graph info when no conanfile exists, and wired CLI overrides (--name, --version, --user, --channel) through jfrog-cli-artifactory so the build-info module ID can still be customized.