Fix issue #15 where escaped escape chars were treated as escape chars#17
Fix issue #15 where escaped escape chars were treated as escape chars#17derek-miller wants to merge 1 commit intojonschlinkert:masterfrom derek-miller:master
Conversation
|
Thanks! I'll take a look at this and get it merged tonight. |
|
Any chance to get this merged, @doowb, @jonschlinkert ? I was bitten by this too, and really need the fix. |
|
Reviewing the pull request again, I suspect that the code counts the number of backslashes before the opening quote, and uses this to decide if the closing quote candidate should be respected. In other words, given the string @derek-miller - I know it's been a while, but did this code work for you? |
|
Hey @derek-miller and @yairk sorry it has been so long. I just noticed the same bug myself, and was about to do a patch, but I'd be happy to accept this one. @yairk if you want to do a patch still I'd probably merge this first so both of you get attribution. It's up to you. |
|
Thanks for following up @jonschlinkert! As I noted above, I believe the current PR is incomplete because it counts the number of backslashes that appear before the opening quote, rather than the closing quote. I'd be happy to submit a patch - LMK if you want me to submit it based on the currently-released code, or if you'd like to merge this PR first. |
No description provided.